New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent saving a newly-added bookmark if the URL is bad #1829

Merged

marcelklehr merged 1 commit into floccusaddon:develop from andybalaam:prevent-adding-bookmark-with-bad-url

Jan 14, 2025

Contributor

andybalaam commented Jan 14, 2025

This is another part of #1826 . Just like in the Edit dialog, avoid saving a newly-shared bookmark if its URL is invalid.


          Prevent saving a newly-added bookmark if the URL is bad

6fae653

marcelklehr approved these changes

View reviewed changes

marcelklehr merged commit f1df170 into floccusaddon:develop

Member

marcelklehr commented Jan 14, 2025

Cool! Thank you for your contribution 💙

andybalaam deleted the prevent-adding-bookmark-with-bad-url branch

January 14, 2025 21:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet